brianyin/ajs-323-support-openai-strict-schema #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 505e79d The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
toubatbrian
commented
Nov 10, 2025
Comment on lines
+302
to
+304
| if (this.strictToolSchema) { | ||
| oaiParams.function.strict = true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
we dynamically assign the strict property
toubatbrian
commented
Nov 10, 2025
| apiKey, | ||
| apiSecret, | ||
| modelOptions, | ||
| strictToolSchema = false, |
Contributor
Author
There was a problem hiding this comment.
disable strict to remain backward competibility
simllll
reviewed
Nov 10, 2025
Contributor
simllll
left a comment
simllll
left a comment
There was a problem hiding this comment.
Nice 👍🏼 looking forward to this :)
davidzhao
approved these changes
Nov 11, 2025
Contributor
Author
|
Wait for #813 |
Merged
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support strict openai tool schema, marked as false by default to remain backward competible.