Removing Vnet with scope default (sonic-net#2239)

* [Vnetorch] Delete vnet vrf object when scope is not default

Author: sumukhatv

orchagent/vnetorch.cpp

@@ -312,11 +312,14 @@ VNetVrfObject::~VNetVrfObject()
     set<sai_object_id_t> vr_ent = getVRids();
     for (auto it : vr_ent)
     {
-        sai_status_t status = sai_virtual_router_api->remove_virtual_router(it);
-        if (status != SAI_STATUS_SUCCESS)
+        if (it != gVirtualRouterId) 
         {
-            SWSS_LOG_ERROR("Failed to remove virtual router name: %s, rv:%d",
-                            vnet_name_.c_str(), status);
+            sai_status_t status = sai_virtual_router_api->remove_virtual_router(it);
+            if (status != SAI_STATUS_SUCCESS)
+            {
+                SWSS_LOG_ERROR("Failed to remove virtual router name: %s, rv:%d",
+                                vnet_name_.c_str(), status);
+            }
         }
         gFlowCounterRouteOrch->onRemoveVR(it);
     }

tests/test_vnet.py

@@ -1439,6 +1439,9 @@ def test_vnet_orch_5(self, dvs, testlog):
         vnet_obj.check_default_vnet_entry(dvs, 'Vnet_5')
         vnet_obj.check_vxlan_tunnel_entry(dvs, tunnel_name, 'Vnet_5', '4789')
 
+        delete_vnet_entry(dvs, 'Vnet_5')
+        vnet_obj.check_default_vnet_entry(dvs, 'Vnet_5')
+
     '''
     Test 6 - Test VxLAN tunnel with multiple maps
     '''