Skip to content

Conversation

@RowanTate
Copy link
Contributor

Added new config that extends base rules with react and react hook rules

@RowanTate RowanTate requested a review from a team as a code owner June 14, 2023 04:35
@RowanTate RowanTate requested a review from philals June 14, 2023 04:40
@philals
Copy link
Contributor

philals commented Jun 14, 2023

I approve, however keen to have @blacha's eyes on it.

@blacha
Copy link
Member

blacha commented Jun 16, 2023

:lgtm: the title needs to be conventional or it would be picked up in change log.

random thought does this need to be a seperate config or can we apply it on all .tsx files?

@RowanTate RowanTate changed the title Add React and React Hook linting rules feat: Add React and React Hook linting rules Jun 19, 2023
@philals
Copy link
Contributor

philals commented Jun 19, 2023

@blacha yeah it could be applied to ALL .tsx files... that use React.. I think one of the fancy new frameworks can also use .tsx... anyway... we'll solve that problem when LINZ starts using Vue.js or what ever the cool kids use these days.

Thinking about it again.. yeah maybe we should.. The non-tsx developers are installing all the dependencies anyway..

Thoughts @RowanTate ?

@RowanTate
Copy link
Contributor Author

:lgtm: the title needs to be conventional or it would be picked up in change log.

random thought does this need to be a seperate config or can we apply it on all .tsx files?

Makes sense. I'll update the PR soon

@blacha blacha added this pull request to the merge queue Jun 20, 2023
Merged via the queue into master with commit b8ec393 Jun 20, 2023
@blacha blacha deleted the add-react-rules branch June 20, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants