⚠️ Potential issue | 🟡 Minor

fd "values.yaml" charts/ --type f

# Check the values.yaml in the specific chart directory
cat -n charts/lfx-v2-indexer-service/values.yaml | head -150

# Look for the otel configuration section in values.yaml
grep -n -A 30 "otel:" charts/lfx-v2-indexer-service/values.yaml

# Check if there are any guards already in deployment.yaml before line 79
sed -n '1,79p' charts/lfx-v2-indexer-service/templates/deployment.yaml | tail -20

Add a nil guard before accessing .Values.app.otel to prevent "<nil>" string injection.

While the default values.yaml defines the otel block, users who override values could potentially omit it. If .Values.app.otel becomes nil, accessing .otel.serviceName returns nil, which converts to the string literal "<nil>" via toString, bypassing the ne "" check and setting OTEL_SERVICE_NAME="<nil>".

Wrap the entire OTEL section in a nil guard:

+            {{- if .Values.app.otel }}
             {{- $otelServiceName := .Values.app.otel.serviceName | toString | trim }}
             {{- if ne $otelServiceName "" }}
             - name: OTEL_SERVICE_NAME
               value: {{ $otelServiceName | quote }}
             {{- end }}
             ...
             {{- end }}
+            {{- end }}

Alternatively, guard each access with default "" before toString:

{{- $otelServiceName := .Values.app.otel.serviceName | default "" | toString | trim }}

The outer guard is cleaner and more efficient.

In `@charts/lfx-v2-indexer-service/templates/deployment.yaml` around lines 79 -
128, The OTEL env var block accesses .Values.app.otel fields directly which can
produce the literal "<nil>" when the otel map is absent; wrap the entire OTEL
section in a nil guard (e.g., `if .Values.app.otel`) so you only compute
$otelServiceName, $otelServiceVersion, $otelEndpoint, $otelProtocol,
$otelInsecure, $otelTracesExporter, $otelTracesSampleRatio,
$otelMetricsExporter, $otelLogsExporter, and $otelPropagators when
.Values.app.otel is non-nil, or alternatively apply `default ""` to each access
(e.g., use `default "" | toString | trim`) to ensure empty strings instead of
"<nil>" before the `ne ""` checks and env var creation.

The values.yaml documentation claims the default for serviceVersion is "1.0.0", but the actual code in otel.go (line 90) doesn't provide any default value for serviceVersion - it uses whatever is in the environment variable or an empty string. This creates a discrepancy between the documented behavior and actual behavior. Either update the code to provide "1.0.0" as the default, or update the documentation to clarify that the default is an empty string.

The default values in values.yaml use explicit values for fields that have documented defaults in the code. For example, protocol: "grpc", insecure: "false", tracesExporter: "none", etc. are set to their default values. This creates redundancy and potential for drift between the documented defaults in otel.go and the Helm chart defaults. Consider setting these to empty strings (like serviceName and endpoint) to allow the Go code defaults to take effect, or add clear comments indicating these values override code defaults.

The default propagators value in values.yaml is "tracecontext,baggage,jaeger" but the code default in otel.go line 118 is "tracecontext,baggage" (without jaeger). This inconsistency means that deployments using default values.yaml will have different behavior than running the application with default environment variables. Consider aligning these defaults or documenting why they differ.