ci: ansible-lint requires dependencies to be installed [citest_skip]

[richm]

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use the newer tox-lsr release and separate Ansible collection conversion from lint and test execution steps.

CI:

• Bump tox-lsr version to 3.18.1 across Ansible-related GitHub workflows.
• Split Ansible collection conversion into a dedicated tox step before running ansible-lint and ansible-test in CI.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr 3.18.1 and refactors ansible-lint and ansible-test jobs to separate the collection conversion step from the lint/test execution, aligning with new dependency-handling behavior in tox-lsr.

Flow diagram for updated ansible-lint GitHub Actions job

flowchart TD
  A[GitHub Actions ansible-lint workflow trigger] --> B[Checkout repository]
  B --> C[Install tox and tox-lsr 3_18_1 via pip3]
  C --> D[Set up Python using actions_setup-python]
  D --> E[Run tox environment collection<br/>tox -e collection]
  E --> F[Run tox environment ansible-lint-collection<br/>tox -e ansible-lint-collection<br/>with LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP<br/>and overridden testenv basepython]
  F --> G[ansible-lint runs against converted collection<br/>with dependencies from meta_collection-requirements_yml<br/>and tests_collection-requirements_yml]
  G --> H[Job completes]

Loading

File-Level Changes

Change	Details	Files
Upgrade tox-lsr to version 3.18.1 across CI workflows to ensure collection dependencies are installed for ansible-lint and tests.	Bump tox-lsr from 3.18.0 to 3.18.1 in ansible-lint workflow installation step. Bump tox-lsr from 3.18.0 to 3.18.1 in ansible-test workflow installation step. Bump tox-lsr from 3.18.0 to 3.18.1 in ansible-managed-var-comment workflow installation step. Bump tox-lsr from 3.18.0 to 3.18.1 in qemu-kvm-integration-tests workflow setup step.	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/qemu-kvm-integration-tests.yml
Refactor ansible-lint workflow to run collection conversion and ansible-lint in distinct tox invocations.	Split the combined collection conversion and ansible-lint step into two separate steps. Add a dedicated step that runs only tox -e collection. Adjust ansible-lint step to set environment variables and run only tox -e ansible-lint-collection with the appropriate basepython override.	.github/workflows/ansible-lint.yml
Refactor ansible-test workflow to run collection conversion and ansible-test in distinct tox invocations.	Split the combined collection conversion and ansible-test step into two separate steps. Add a dedicated step that runs only tox -e collection. Adjust ansible-test step to run only the specific ansible-test environment (e.g. ansible-test-${{ matrix.versions.ansible }}) while still overriding basepython via tox's -x option.	.github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• You now hardcode the tox-lsr version string in multiple workflows; consider centralizing it via a workflow-level env variable or YAML anchor so future version bumps only need to be made in one place.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- You now hardcode the tox-lsr version string in multiple workflows; consider centralizing it via a workflow-level env variable or YAML anchor so future version bumps only need to be made in one place.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}