Skip to content

Commit 9415d37

Browse files
q2vendavem330
authored andcommitted
rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().
The cited commit accidentally replaced tgt_net with net in rtnl_dellink(). As a result, IFLA_TARGET_NETNSID is ignored if the interface is specified with IFLA_IFNAME or IFLA_ALT_IFNAME. Let's pass tgt_net to rtnl_dev_get(). Fixes: cc6090e ("net: rtnetlink: introduce helper to get net_device instance by ifname") Signed-off-by: Kuniyuki Iwashima <[email protected]> Reviewed-by: Jakub Kicinski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 799a829 commit 9415d37

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/core/rtnetlink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3288,7 +3288,7 @@ static int rtnl_dellink(struct sk_buff *skb, struct nlmsghdr *nlh,
32883288
if (ifm->ifi_index > 0)
32893289
dev = __dev_get_by_index(tgt_net, ifm->ifi_index);
32903290
else if (tb[IFLA_IFNAME] || tb[IFLA_ALT_IFNAME])
3291-
dev = rtnl_dev_get(net, tb);
3291+
dev = rtnl_dev_get(tgt_net, tb);
32923292
else if (tb[IFLA_GROUP])
32933293
err = rtnl_group_dellink(tgt_net, nla_get_u32(tb[IFLA_GROUP]));
32943294
else

0 commit comments

Comments
 (0)