fix(cozy-sharing): Avoid rendering email twice in recipient row

When a recipient has no public_name or name field, getDisplayName
falls back to the email for the primary text. The secondary text
rendered by MemberRecipientStatus was also showing the email,
producing a duplicate.

Pass the raw recipient name through a new optional prop so
MemberRecipientStatus can suppress the email in the secondary text
when it would duplicate the primary, while still showing the
instance when there is no email at all.

Author: doubleface

packages/cozy-sharing/src/components/Recipient/GroupRecipientDetailWithAccess.jsx

@@ -39,6 +39,7 @@ const GroupRecipientDetailWithAccess = ({ withAccess }) => {
                     isMe={isMe}
                     instance={recipient.instance}
                     email={recipient.email}
+                    name={recipient.name || recipient.public_name}
                   />
                 }
               />

packages/cozy-sharing/src/components/Recipient/MemberRecipient.jsx

@@ -67,6 +67,7 @@ const MemberRecipient = props => {
               isMe={isMe}
               instance={instance}
               email={rest.email}
+              name={rest.name || rest.public_name}
             />
           }
         />

packages/cozy-sharing/src/components/Recipient/MemberRecipientLite.jsx

@@ -39,6 +39,7 @@ const MemberRecipientLite = ({ recipient, isOwner, ...props }) => {
             isMe={isMe}
             instance={recipient.instance}
             email={recipient.email}
+            name={recipient.name || recipient.public_name}
             typographyProps={{ noWrap: true }}
           />
         }

packages/cozy-sharing/src/components/Recipient/MemberRecipientStatus.jsx

@@ -9,6 +9,7 @@ const MemberRecipientStatus = ({
   isMe,
   instance,
   email,
+  name,
   typographyProps
 }) => {
   const { t } = useI18n()
@@ -17,7 +18,11 @@ const MemberRecipientStatus = ({
   const isReady = isMe || status === 'ready' || status === 'owner'
   let text
   if (isReady) {
-    text = email || instance
+    // Hide the email when the parent already uses it as the primary text
+    // (getDisplayName falls back to email when the recipient has no name).
+    // Keep the instance visible when there is no email at all, so the user
+    // can still tell the recipient lives on a different Cozy instance.
+    text = isMe || name || !email ? email || instance : ''
   } else if (isSendingEmail) {
     text = t('Share.status.mail-not-sent')
   } else {
@@ -39,6 +44,7 @@ MemberRecipientStatus.propTypes = {
   isMe: PropTypes.bool,
   instance: PropTypes.string,
   email: PropTypes.string,
+  name: PropTypes.string,
   typographyProps: PropTypes.object
 }
 

packages/cozy-sharing/src/components/Recipient/MemberRecipientStatus.spec.jsx

@@ -0,0 +1,97 @@
+import { render } from '@testing-library/react'
+import React from 'react'
+
+import MemberRecipientStatus from './MemberRecipientStatus'
+import AppLike from '../../../test/AppLike'
+
+describe('MemberRecipientStatus component', () => {
+  const setup = props =>
+    render(
+      <AppLike>
+        <MemberRecipientStatus {...props} />
+      </AppLike>
+    )
+
+  it('should show email when status is ready and recipient has a name', () => {
+    const { getByText } = setup({
+      status: 'ready',
+      isMe: false,
+      email: 'other@example.com',
+      instance: 'foo.mycozy.cloud',
+      name: 'Other Person'
+    })
+    expect(getByText('other@example.com')).toBeTruthy()
+  })
+
+  it('should render nothing when recipient has no name and status is ready', () => {
+    const { queryByText } = setup({
+      status: 'ready',
+      isMe: false,
+      email: 'other@example.com',
+      instance: 'foo.mycozy.cloud'
+    })
+    expect(queryByText('other@example.com')).toBe(null)
+    expect(queryByText('foo.mycozy.cloud')).toBe(null)
+  })
+
+  it('should show email when isMe is true regardless of status', () => {
+    const { getByText } = setup({
+      status: 'pending',
+      isMe: true,
+      email: 'me@example.com'
+    })
+    expect(getByText('me@example.com')).toBeTruthy()
+  })
+
+  it('should fallback to instance when email is missing and status is ready', () => {
+    const { getByText } = setup({
+      status: 'ready',
+      isMe: false,
+      instance: 'foo.mycozy.cloud'
+    })
+    expect(getByText('foo.mycozy.cloud')).toBeTruthy()
+  })
+
+  it('should show email when status is owner, not isMe, and recipient has a name', () => {
+    const { getByText } = setup({
+      status: 'owner',
+      isMe: false,
+      email: 'owner@example.com',
+      instance: 'foo.mycozy.cloud',
+      name: 'Owner Person'
+    })
+    expect(getByText('owner@example.com')).toBeTruthy()
+  })
+
+  it('should show "Sending invitation mail..." when status is mail-not-sent and not isMe', () => {
+    const { getByText } = setup({
+      status: 'mail-not-sent',
+      isMe: false
+    })
+    expect(getByText('Sending invitation mail...')).toBeTruthy()
+  })
+
+  it('should show "Invitation sent" when status is pending', () => {
+    const { getByText } = setup({
+      status: 'pending',
+      isMe: false
+    })
+    expect(getByText('Invitation sent')).toBeTruthy()
+  })
+
+  it('should show "Invitation seen" when status is seen', () => {
+    const { getByText } = setup({
+      status: 'seen',
+      isMe: false
+    })
+    expect(getByText('Invitation seen')).toBeTruthy()
+  })
+
+  it('should fallback to "Invitation sent" for unknown status', () => {
+    const { getByText } = setup({
+      status: 'unknown-status',
+      isMe: false
+    })
+    expect(getByText('Invitation sent')).toBeTruthy()
+  })
+})