tapcfg: enable orphan utxo sweeping by default

Author: darioAnongba

itest/tapd_harness.go

@@ -261,7 +261,9 @@ func newTapdHarness(t *testing.T, ht *harnessTest, cfg tapdConfig,
 	tapCfg.Universe.DisableSupplyVerifierChainWatch = opts.disableSupplyVerifierChainWatch
 
 	// Pass through the sweep orphan UTXOs flag. If the option was not set,
-	// this will be false, which is the default.
+	// this will be false. Note: The production default is true, but we
+	// disable it by default in tests to avoid interference with test
+	// assertions unless explicitly enabled via WithSweepOrphanUtxos().
 	tapCfg.Wallet.SweepOrphanUtxos = opts.sweepOrphanUtxos
 
 	switch {

sample-tapd.conf

@@ -417,8 +417,8 @@
 ; wallet.psbt-max-fee-ratio=0.75
 
 ; Sweep orphaned UTXOs into send and burn anchor transactions.
-; Disabled by default.
-; wallet.sweep-orphan-utxos=false
+; Enabled by default.
+; wallet.sweep-orphan-utxos=true
 
 [address]
 

tapcfg/config.go

@@ -297,7 +297,7 @@ type WalletConfig struct {
 
 	// SweepOrphanUtxos, when true, sweeps orphaned UTXOs into anchor
 	// transactions created during sends and burns.
-	SweepOrphanUtxos bool `long:"sweep-orphan-utxos" description:"Sweep orphaned UTXOs into anchor transactions created during sends and burns. Disabled by default."`
+	SweepOrphanUtxos bool `long:"sweep-orphan-utxos" description:"Sweep orphaned UTXOs into anchor transactions created during sends and burns. Enabled by default."`
 }
 
 // UniverseConfig is the config that houses any Universe related config
@@ -498,7 +498,7 @@ func DefaultConfig() Config {
 		},
 		Wallet: &WalletConfig{
 			PsbtMaxFeeRatio:  DefaultPsbtMaxFeeRatio,
-			SweepOrphanUtxos: false,
+			SweepOrphanUtxos: true,
 		},
 		AddrBook: &AddrBookConfig{
 			DisableSyncer: false,