emscripten: Move fill-document from hint/property to a window flag. #14619
+87
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note that this totally removes the property (reasonable, it's now a flag), but also the hint, which is programmatically fine, but it means end users can't override this...but maybe that's the right call, as it might introduce breaking bugs if a window isn't expecting to be resized. |
slouken
approved these changes
Dec 7, 2025
Collaborator
slouken
left a comment
slouken
left a comment
There was a problem hiding this comment.
Looks great! This is a nice cleanup. :)
Can you update WhatsNew.txt as well?
icculus
force-pushed
the
sdl3-window-filldoc-flag
branch
from
fc09f88 to
c4650d2
Compare
Collaborator
Author
|
Updated WhatsNew.txt in fc09f88. Then rebased this down to a single commit to merge. I'll click The Big Green Button once the builders clear it one more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14617.