Skip to content

Commit 7c5d76c

Browse files
authored
refactor: remove context parameter and unused deps from InstanceRepository (#7466)
* Refactor: Remove context parameter from InstanceRepository The `Context` parameter was unused in the `InstanceRepository` constructor and has been removed. This simplifies the class and its instantiation. * Refactor: remove unused imports in InstanceRepository The `Context` and `R` imports were not used in `InstanceRepository.kt` and have been removed.
1 parent 620416b commit 7c5d76c

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

app/src/main/java/com/github/libretube/api/InstanceRepository.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
package com.github.libretube.api
22

3-
import android.content.Context
4-
import com.github.libretube.R
53
import com.github.libretube.api.RetrofitInstance.PIPED_API_URL
64
import com.github.libretube.api.obj.PipedInstance
75
import kotlinx.coroutines.Dispatchers
86
import kotlinx.coroutines.withContext
97
import okhttp3.HttpUrl.Companion.toHttpUrl
108

11-
class InstanceRepository(private val context: Context) {
9+
class InstanceRepository {
1210

1311
/**
1412
* Fetch official public instances from kavin.rocks

app/src/main/java/com/github/libretube/ui/models/WelcomeViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ class WelcomeViewModel(
116116
val Factory: ViewModelProvider.Factory = viewModelFactory {
117117
initializer {
118118
WelcomeViewModel(
119-
instanceRepository = InstanceRepository(this[APPLICATION_KEY]!!),
119+
instanceRepository = InstanceRepository(),
120120
savedStateHandle = createSavedStateHandle(),
121121
)
122122
}

app/src/main/java/com/github/libretube/ui/preferences/InstanceSettings.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ class InstanceSettings : BasePreferenceFragment() {
5555

5656
lifecycleScope.launch {
5757
// update the instances to also show custom ones
58-
initInstancesPref(instancePrefs, InstanceRepository(appContext).getInstancesFallback())
58+
initInstancesPref(instancePrefs, InstanceRepository().getInstancesFallback())
5959

6060
// try to fetch the public list of instances async
61-
val instanceRepo = InstanceRepository(appContext)
61+
val instanceRepo = InstanceRepository()
6262
val instances = instanceRepo.getInstances()
6363
.onFailure {
6464
appContext.toastFromMainDispatcher(it.message.orEmpty())

0 commit comments

Comments
 (0)