This repository was archived by the owner on Dec 8, 2023. It is now read-only.
Exclude the source property from measurements sent to /measurements, …#91
Merged
bryanmikaelian merged 2 commits intolibrato:masterfrom May 18, 2017
Merged
Conversation
…as it it invalid to include in the posted request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…as it it invalid to include in the posted request.
Measurements are constructed with a
sourceproperty, but the API definition doesn't have that property in thePOSTrequest body to/v1/measurements(https://www.librato.com/docs/api/#measurements). If that property is there, a400 Bad Requestis returned from the API, with the following detail{"code":400,"message":"Unable to process JSON"}.In the PR, the
sourceis deleted off the measurement prior to being added to the collection. I left it as a property because thelegacyMeasureexpects that property to be there in order to create itself throughextend.