Skip to content

Commit b2c4d7b

Browse files
committed
260214.084628.CET revise comments in test_flang.yml and test_gfortran.yml about why we skip the extensive Fortran tests on Windows
1 parent be4f7a9 commit b2c4d7b

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

.github/workflows/test_flang.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,13 @@ jobs:
149149
echo "IK=${IK}"
150150
echo "IK=${IK}" >> "$GITHUB_ENV"
151151
152-
# 20260213: We skip the linting and extensive test on Windows due to the following
153-
# reasons. The examples will still be tested on Windows.
154-
# 1. Windows does not support the symlink of linux, and hence mlint and flint do not work.
152+
# 20260213: We skip the extensive test on Windows due to the following reasons. The
153+
# examples will still be tested on Windows.
154+
# 0. It is quite difficult to debug on Windows. We choose to develop and debug the code on
155+
# Linux and macOS, and only run a quick test on Windows to see whether it works at all.
156+
# 1. Windows does not support the symlink of Linux. Makefile will fail when copying source files.
155157
# 2. Makefile.common does not work on Windows for the moment due to quotation marks.
156-
# Nevertheless, we should still define IK etc., as they will be used when defining the
157-
# artifact names.
158+
# Nevertheless, we should still define IK etc., as they will be used when defining the artifact names.
158159
if [[ "$RUNNER_OS" != "Windows" ]] ; then
159160
cd "$ROOT_DIR"/fortran/tests && make ftest_${IK}.${{ matrix.solver }}
160161
fi

.github/workflows/test_gfortran.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,13 @@ jobs:
141141
echo "FFLAGS=$FFLAGS"
142142
echo "FFLAGS=$FFLAGS" >> "$GITHUB_ENV"
143143
144-
# 20221212: We skip the linting and extensive test on Windows due to the following
145-
# reasons. The examples will still be tested on Windows.
146-
# 1. Windows does not support the symlink of linux, and hence mlint and flint do not work.
144+
# 20260213: We skip the extensive test on Windows due to the following reasons. The
145+
# examples will still be tested on Windows.
146+
# 0. It is quite difficult to debug on Windows. We choose to develop and debug the code on
147+
# Linux and macOS, and only run a quick test on Windows to see whether it works at all.
148+
# 1. Windows does not support the symlink of Linux. Makefile will fail when copying source files.
147149
# 2. Makefile.common does not work on Windows for the moment due to quotation marks.
148-
# Nevertheless, we should still define IK etc., as they will be used when defining the
150+
# Nevertheless, we should still define IK etc., as they will be used when defining the artifact names.
149151
if [[ "$RUNNER_OS" != "Windows" ]] ; then
150152
cd "$ROOT_DIR"/fortran/tests && make gtest_${IK}_c.${{ matrix.solver }} && make gtest_${IK}.${{ matrix.solver }}
151153
fi

0 commit comments

Comments
 (0)