[PluginID] Add support for over 255 pluginIDs #5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For upcoming MQTT TLS feature
GPS is one of the very few use cases, where the resolution of a float is not enough. A float only has a resolution of 6 decimals. However, when you are located at a location where the latitude or longitude requires 2 or 3 decimal places to represent the degrees, not a lot of resolution is left to pinpoint the actual position. Before this fix, the standard deviation of my position (53 degree North, 6 East) was about 15 - 20 meters on a stationary GPS module. With this fix, the standard deviation is about 5 meter for the same stationary GPS modules.
TaskValueData_t is now forced 32-bit aligned to fix other issues, so we must copy it byte aligned to/from the p2p struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're getting close to the current hard limit of 255 plugin IDs, it is time to start implementing support for over 255 plugins in such a way that it is fully compatible with existing builds and settings.
ToDo: