ADD: index_count, more context for templates. UPDATE: ZZZ template, textures only components, and index_count usage #62
Conversation
templates/Zenless Zone Zero.ini.j2
Outdated
| this = Resource{{part.fullname}}{{ texture.name }} | ||
|
|
||
| {% endfor %} | ||
| {% for data in mod_file.hash_data if data.draw_vb == "" and data.position_vb == "" and copy_textures%} |
There was a problem hiding this comment.
this block is redundant after 1.6.3 update
… improve index_count handling
| credit=self.credit, | ||
| game=self.game, | ||
| character_name=self.mod_name, | ||
| apply_modifiers=self.apply_modifiers, |
There was a problem hiding this comment.
the export settings should already be passed as attributes of mod_info
There was a problem hiding this comment.
can't find any kind of mod_info
| @dataclass | ||
| class Part: | ||
| fullname: str | ||
| name: str |
There was a problem hiding this comment.
name and classification both in Part and Component classes is redundant as the information from hash.json is already passed to the templates
There was a problem hiding this comment.
that's for usage simplicity, to not require users to sync getting info from object and from hash.json, and just use object info
| obj for obj in candidate_objs if obj.name.startswith(current_name) | ||
| ] | ||
| if len(comp_matching_objs) == 0: | ||
| if len(comp_matching_objs) == 0 and component["draw_vb"] != "": |
There was a problem hiding this comment.
This change is odd- it is already like on the added side of things. Perhaps you need to rebase your branch?
|
|
||
| {% block overridesibs %} | ||
| {% for component in mod_file.components if component.draw_vb != "" %} | ||
| [TextureOverride{{component.fullname}}IB] |
There was a problem hiding this comment.
removal of the global handling skip for a IB section can lead to issues.
If a given IB gets more parts added to it in a subsequent version of the game it would only skip the ones the ini covers but not all of them making mods look functional but have a broken IB on top of it.
There was a problem hiding this comment.
that's intentional to not have stray IB sections with just handling = skip, cuz those lead into issues w/o at least index filtering
There was a problem hiding this comment.
What kind of issues? Any specific bug or simply misinterpretation from users?
Do they outweight the scenario I presented?
There was a problem hiding this comment.
Issue like that, or that, and anything similar to them, when there stray skips of hair, or some small items like Mimiyabi hairpin, those will cause multiple issues with world, and having just first_index for them may not help, and need to have both index filters at least, can't remember if more was needed ever, but potentially might be
| uv.lock | ||
| .python-version | ||
| TODO.md | ||
| .idea/ |
Filter parts based on vertex count and draw_vb condition.
2 participants
No description provided.