Skip to content

Add support for msvc#12

Closed
yagoulas wants to merge 1 commit intoleapcode:developfrom
yagoulas:msvc-build
Closed

Add support for msvc#12
yagoulas wants to merge 1 commit intoleapcode:developfrom
yagoulas:msvc-build

Conversation

@yagoulas
Copy link
Contributor

Motivation

In the OpenBazaar project we use pysqlcipher and we are preparing a build for Windows. We would like to be able to use Visual Studio to compile pysqlcipher for Windows instead of using cygwin with mingw. Most of our dependencies support compilation with Visual Studio but pysqlcipher doesn't.

Fix

In this patch I have added a check for the win32 platform. When win32 platform is detected the parameters of the compiler and linker are altered in order to let visual studio compile pysqlcipher. The first step is to detect OpenSSL by checking an environment variable that is set when OpenSSL is installed. Then the directories include and lib of the openssl directory are passed to the compiler and the linker. In Windows libcrypto of OpenSSL is called libeay32, so pysqlcipher should link to libeay32.lib.
It should be also noted here that amalgamation.c doesn't compile out of the box with Visual Studio so this patch also adds a define that allows the compiler to work fine.

@dionyziz
Copy link

dionyziz commented Nov 9, 2014

This is a critical issue for us. Could we please get some feedback on whether there is interest to merge this? Thank you.

@kalikaneko
Copy link
Member

hi @dionyziz
there's definitely interest. i will go through it today.

@kalikaneko
Copy link
Member

merged into develop. will release new release with this fix soon.

@dionyziz
Copy link

Thank you!

@yagoulas yagoulas closed this Nov 13, 2014
@yagoulas yagoulas deleted the msvc-build branch November 13, 2014 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants