Closed
Conversation
|
This is a critical issue for us. Could we please get some feedback on whether there is interest to merge this? Thank you. |
Member
|
hi @dionyziz |
Member
|
merged into develop. will release new release with this fix soon. |
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the OpenBazaar project we use pysqlcipher and we are preparing a build for Windows. We would like to be able to use Visual Studio to compile pysqlcipher for Windows instead of using cygwin with mingw. Most of our dependencies support compilation with Visual Studio but pysqlcipher doesn't.
Fix
In this patch I have added a check for the win32 platform. When win32 platform is detected the parameters of the compiler and linker are altered in order to let visual studio compile pysqlcipher. The first step is to detect OpenSSL by checking an environment variable that is set when OpenSSL is installed. Then the directories include and lib of the openssl directory are passed to the compiler and the linker. In Windows libcrypto of OpenSSL is called libeay32, so pysqlcipher should link to libeay32.lib.
It should be also noted here that amalgamation.c doesn't compile out of the box with Visual Studio so this patch also adds a define that allows the compiler to work fine.