-
Notifications
You must be signed in to change notification settings - Fork 13
Add configurable FlutterSecureStorage to FlutterSecureCredentialsStorage #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
14
commits into
master
Choose a base branch
from
copilot/fix-478
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialsStorage Co-authored-by: PiotrRogulski <[email protected]>
Co-authored-by: PiotrRogulski <[email protected]>
Copilot
AI
changed the title
[WIP] [login_client_flutter] Allow configuring
Add configurable FlutterSecureStorage to FlutterSecureCredentialsStorage
Aug 22, 2025
FlutterSecureStorage
Copilot finished work on behalf of
PiotrRogulski
August 22, 2025 09:24
packages/login_client_flutter/lib/src/flutter_secure_credentials_storage.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: PiotrRogulski <[email protected]>
Copilot finished work on behalf of
PiotrRogulski
August 22, 2025 09:32
packages/login_client_flutter/lib/src/flutter_secure_credentials_storage.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: PiotrRogulski <[email protected]>
Copilot finished work on behalf of
PiotrRogulski
August 22, 2025 09:37
49daf8c to
c1c39a6
Compare
c1c39a6 to
1be10e1
Compare
Member
|
@copilot Update the changelog and the package version |
…ble FlutterSecureStorage feature Co-authored-by: PiotrRogulski <[email protected]>
Contributor
Author
Copilot finished work on behalf of
PiotrRogulski
August 22, 2025 10:20
Co-authored-by: PiotrRogulski <[email protected]>
Copilot finished work on behalf of
PiotrRogulski
August 22, 2025 10:26
Co-authored-by: PiotrRogulski <[email protected]>
Copilot finished work on behalf of
PiotrRogulski
August 22, 2025 10:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FlutterSecureCredentialsStorageclass previously created the underlyingFlutterSecureStoragewith default options, making it impossible to configure platform-specific settings like KeyChain accessibility on iOS.This PR adds an optional
storageparameter to the constructor, allowing users to provide a customFlutterSecureStorageinstance with specific configuration options:Key features:
The implementation uses a private field to store the custom storage and a getter that falls back to the default instance when no custom storage is provided, ensuring minimal code changes while preserving all existing functionality.
Fixes #478.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl-ssl.google.comcurl -fsSL REDACTED(dns block)esm.ubuntu.com/usr/lib/apt/methods/https(dns block)https://api.github.com/repos/flutter/flutter/releases/latestcurl -s REDACTED(http block)https://storage.googleapis.com/flutter_infra_release/flutter/1e9a811bf8e70466596bcf0ea3a8b5adb5f17f7f/dart-sdk-linux-x64.zipcurl --retry 3 --continue-at - --location --output /tmp/flutter/bin/cache/dart-sdk-linux-x64.zip REDACTED(http block)https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.24.3-stable.tar.xzwget -q REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.