Highlight box rendering #764
Conversation
Allow boxes to render through blocks
| matrixStack.scale(-0.014f, -0.014f, 0.014f); | ||
|
|
||
| final float backgroundTextOpacity = Minecraft.getInstance().options.getBackgroundOpacity(0.25F); | ||
| final float backgroundTextOpacity = 0f; |
There was a problem hiding this comment.
I'm kinda against this, one just don't render white text on light background
There was a problem hiding this comment.
the way minecraft renders the background behind the text, just messes up the text. Without it is always better
There was a problem hiding this comment.
That's bug in forge, and there was a pr upstream to fix it, please do not port to 1.21.
Also without it it's 50% times worse, not sure how you can see white on bright colors, but I don't
There was a problem hiding this comment.
1.21 had the exact same issue
| .setShaderState(POSITION_COLOR_SHADER) | ||
| .setTransparencyState(TRANSLUCENT_TRANSPARENCY) | ||
| .setDepthTestState(LEQUAL_DEPTH_TEST) | ||
| .setDepthTestState(AlwaysDepthTestStateShard.ALWAYS_DEPTH_TEST) |
There was a problem hiding this comment.
This might (will) require changes elsewhere, cuz sorting. I kinda don't care whether we render whole or not, but it might be kinda noisy if too many are on screen
There was a problem hiding this comment.
we'll see if it gets too noise with multiple schematics, though the tag tool rendering does require it to be able to see tagged blocks behind walls
There was a problem hiding this comment.
The single block highlights need adjusting, Mirality already had some decent ideas in mcol
This reverts commit bbba7a9.
Changes proposed in this pull request
Remove background from text rendering
Allow boxes to render through blocks
Testing
Review please