Skip to content

fix 732 & 731 #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

fix 732 & 731 #743

merged 1 commit into from
May 10, 2025

Conversation

@Raycoms
Copy link
Contributor

@Raycoms Raycoms commented May 10, 2025 •
edited
Loading

Closes #731
Closes #732

Changes proposed in this pull request

  • Compression of nbt read/write seems to leave leftover data in edge cases. Non compressed works fine. Network compresses later differently anyway.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@Nightenom Nightenom merged commit 692177e into version/1.21 May 10, 2025
5 checks passed
@Nightenom Nightenom deleted the fix/731-732 branch May 10, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nightenom Nightenom Nightenom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Raycoms @Nightenom