Skip to content

fix(H-04): race condition #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2025
Merged

fix(H-04): race condition #1575

merged 4 commits into from
Aug 4, 2025

Conversation

@ypatil12
Copy link
Collaborator

@ypatil12 ypatil12 commented Jul 29, 2025 •
edited
Loading

Motivation:

  • There is an offchain race condition where updating the table can cause the entire service to panic if it is frontrun by another tx

Modifications:

  • Return if the table has already been updated
  • Clean up integration testing lib

Result:

  • Clear off chain responses

@ypatil12 ypatil12 force-pushed the release-dev/multichain-pt2-audit-fixes branch from ba2593b to 7f0eb6e Compare July 30, 2025 15:34
nadir-akhtar
nadir-akhtar reviewed Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@nadir-akhtar nadir-akhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, though unit tests need to be updated and there's an interface commit that would merit removal

@ypatil12 ypatil12 force-pushed the release-dev/multichain-pt2-audit-fixes branch from 1808b41 to 8f39d42 Compare August 4, 2025 13:51
@ypatil12 ypatil12 force-pushed the fix/h6-race-condition branch from 8ddc053 to 91ad7df Compare August 4, 2025 15:13
@ypatil12 ypatil12 force-pushed the fix/h6-race-condition branch from d70eba3 to a9366c1 Compare August 4, 2025 19:56
@ypatil12 ypatil12 changed the title fix(h-06): race condition fix(h-04): race condition Aug 4, 2025
@ypatil12 ypatil12 merged commit 34ed4a5 into release-dev/multichain-pt2-audit-fixes Aug 4, 2025
10 checks passed
@ypatil12 ypatil12 deleted the fix/h6-race-condition branch August 4, 2025 20:20
@ypatil12 ypatil12 mentioned this pull request Aug 6, 2025
Merged
@ypatil12 ypatil12 changed the title fix(h-04): race condition fix(H-04): race condition Aug 6, 2025
ypatil12 added a commit that referenced this pull request Aug 8, 2025
@ypatil12
fix(h-04): race condition (#1575)
ee8a74a 
**Motivation:**

- There is an offchain race condition where updating the table can cause
the entire service to panic if it is frontrun by another tx

**Modifications:**

- Return if the table has already been updated
- Clean up integration testing lib 

**Result:**

- Clear off chain responses
ypatil12 added a commit that referenced this pull request Aug 11, 2025
@ypatil12
fix: multichain pt2 audit fixes (#1592)
5e133a1 
**Multichain pt2 Audit Fixes:**

**High:**
- #1575 
- #1569 

**Medium:**
- #1580 

**Low:**
- #1589 

**Misc**
- #1561 
- #1587 
- #1584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nadir-akhtar nadir-akhtar nadir-akhtar approved these changes

Assignees

No one assigned

Labels

⚖️ Audit Fix Audit-related fixes. 🌎 Multichain

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ypatil12 @nadir-akhtar