fix: remove unused constants and add gap #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Clean up unused constants and ensure upgrade safety by adding a storage gap.
- Remove two unused constants from KeyRegistrarStorage to streamline the contract.
- Add a reserved
__gaparray in ECDSACertificateVerifierStorage for future storage layout changes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/contracts/permissions/KeyRegistrarStorage.sol | Deleted two internal constants that were no longer used. |
| src/contracts/multichain/ECDSACertificateVerifierStorage.sol | Introduced an __gap storage slot with documentation for upgradeable contracts. |
eigenmikem
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix missing gap and cleanup unused constants
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.