feat: Add support for provider events. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Jun 10, 2024
kinyoklion
commented
Jun 10, 2024
| self.emit_provider_configuration_changed(ProviderEventDetails(flags_changed=[change.key])) | ||
| pass | ||
|
|
||
| def initialize(self, evaluation_context: EvaluationContext): |
Member
Author
There was a problem hiding this comment.
This should handle the cases where the client failed or succeeded within the start_wait period, or where it exceeded that period and the data source later becomes VALID or OFF.
keelerm84
approved these changes
Jun 11, 2024
tests/test_provider.py
Outdated
| try: | ||
| api.set_provider(openfeature_provider) | ||
| # The method should throw | ||
| assert False |
Member
There was a problem hiding this comment.
I think you can also do this, which is probably slightly preferred.
Suggested change
| assert False | |
| pytest.fail("set_provider should have raised an exception") |
Co-authored-by: Matthew M. Keeler <[email protected]>
Co-authored-by: Matthew M. Keeler <[email protected]>
kinyoklion
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](0.1.2...0.2.0) (2024-06-11) ### Features * Add support for provider events. ([#12](#12)) ([c69231a](c69231a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.