Skip to content

Conversation

@amirhshokri
Copy link
Contributor

@amirhshokri amirhshokri commented Nov 27, 2025

Description

Currently, the Monitoring sidebar link only highlights for /monitoring routes.

When viewing recent jobs or failed jobs originating from Monitoring (/jobs/jobs/:jobId or /jobs/failed/:jobId), the link does not highlight, even though these jobs logically belong to Monitoring.

This PR updates the Monitoring <router-link> to highlight whenever:

  • The path starts with /monitoring.
  • The current job preview’s :type is jobs or failed (which correspond to Monitoring jobs).

Why?

The /jobs/:type/:jobId route is shared across multiple job types:

  • jobs → Recent Jobs tab in Monitoring
  • failed → Failed Jobs tab in Monitoring
  • pending → Pending Jobs
  • completed → Completed Jobs
  • silenced → Silenced Jobs

Only jobs and failed should highlight Monitoring. Other types highlight their respective sidebar links.

Routes reference

{
path: '/monitoring',
children: [
{
path: '',
name: 'monitoring',
component: monitoring,
},
{
path: ':tag',
component: monitoringTag,
children: [
{
path: 'jobs',
name: 'monitoring-jobs',
component: monitoringTagJobs,
props: { type: 'jobs' },
},
{
path: 'failed',
name: 'monitoring-failed',
component: monitoringTagJobs,
props: { type: 'failed' },
},
],
},
],
},

@amirhshokri amirhshokri deleted the 5.x-highlight-monitoring branch November 27, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants