[5.x] Highlight Monitoring sidebar link for job preview pages #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Monitoring sidebar link only highlights for
/monitoringroutes.When viewing
recent jobsorfailed jobsoriginating from Monitoring (/jobs/jobs/:jobIdor/jobs/failed/:jobId), the link does not highlight, even though these jobs logically belong to Monitoring.This PR updates the Monitoring
<router-link>to highlight whenever:/monitoring.:typeisjobsorfailed(which correspond to Monitoring jobs).Why?
The
/jobs/:type/:jobIdroute is shared across multiple job types:jobs→ Recent Jobs tab in Monitoringfailed→ Failed Jobs tab in Monitoringpending→ Pending Jobscompleted→ Completed Jobssilenced→ Silenced JobsOnly
jobsandfailedshould highlight Monitoring. Other types highlight their respective sidebar links.Routes reference
horizon/resources/js/routes.js
Lines 25 to 52 in f4e05f9