[5.3] Add partition collection method

[freekmurze]

The partition method returns a collection with two elements. Items in the first element did pass the given $callback, items in the second element did not.

Here's an example:

collect(range(1, 10))->partition(function ($i) {
    return $i <= 5;
});

// returns a new collection
// first element is a collection with items 1, 2 ,3, 4, 5
// second element is a collection with items 5, 6, 7, 8, 9, 10

[taylorotwell]

Shouldn't you just return the plain array so you can separate them using lists?

[freekmurze]

Yup, changed it to output a plain array.

[JosephSilber]

Actually, list works on collections, so I think we should definitely return a collection.

Really no collection method should ever return a plain array. You don't ever want to break the chain.

[GrahamCampbell]

Looks cool. It should be noted that the strict definition of a partition requires it to be non-empty, though, I guess it's probably ok in practical terms.

[GrahamCampbell]

Please format like the other phpdoc, then looks good. 👍

[freekmurze]

I'm afraid I don't see the formatting problem. Could you tell what's wrong with the current formatting?

[GrahamCampbell]

Short descriptions must be "sort". Exactly one sentence and one line. The rest must be separated.

[freekmurze]

Got it, thanks for clarifying