simplify math

Charlie Kassel · Charlie Kassel · commit d3b784d3eb00 · 2017-06-11T16:37:56.000+01:00
diff --git a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
@@ -478,8 +478,7 @@ protected function failsRatioCheck($parameters, $width, $height)
             [1, 1], array_filter(sscanf($parameters['ratio'], '%f/%d'))
         );
 
-        $maxDimension = max($width, $height);
-        $precision = $maxDimension / $maxDimension ** 2;
+        $precision = 1 / max($width, $height);
 
         return abs($numerator / $denominator - $width / $height) > $precision;
     }

Original file line number	Diff line number	Diff line change
`@@ -478,8 +478,7 @@ protected function failsRatioCheck($parameters, $width, $height)`
`478`	`478`	`[1, 1], array_filter(sscanf($parameters['ratio'], '%f/%d'))`
`479`	`479`	`);`
`480`	`480`
`481`		`- $maxDimension = max($width, $height);`
`482`		`- $precision = $maxDimension / $maxDimension ** 2;`
	`481`	`+ $precision = 1 / max($width, $height);`
`483`	`482`
`484`	`483`	`return abs($numerator / $denominator - $width / $height) > $precision;`
`485`	`484`	`}`