Refactoring tests (#22226)

Author: carusogabriel

tests/Http/HttpMimeTypeTest.php

@@ -36,6 +36,6 @@ public function testGetAllMimeTypes()
     public function testSearchExtensionFromMimeType()
     {
         $this->assertSame('mov', MimeType::search('video/quicktime'));
-        $this->assertSame(null, MimeType::search('foo/bar'));
+        $this->assertNull(MimeType::search('foo/bar'));
     }
 }

tests/Support/SupportArrTest.php

@@ -68,14 +68,14 @@ public function testCrossJoin()
         );
 
         // With 1 empty dimension
-        $this->assertSame([], Arr::crossJoin([], ['a', 'b'], ['I', 'II', 'III']));
-        $this->assertSame([], Arr::crossJoin([1, 2], [], ['I', 'II', 'III']));
-        $this->assertSame([], Arr::crossJoin([1, 2], ['a', 'b'], []));
+        $this->assertEmpty(Arr::crossJoin([], ['a', 'b'], ['I', 'II', 'III']));
+        $this->assertEmpty(Arr::crossJoin([1, 2], [], ['I', 'II', 'III']));
+        $this->assertEmpty(Arr::crossJoin([1, 2], ['a', 'b'], []));
 
         // With empty arrays
-        $this->assertSame([], Arr::crossJoin([], [], []));
-        $this->assertSame([], Arr::crossJoin([], []));
-        $this->assertSame([], Arr::crossJoin([]));
+        $this->assertEmpty(Arr::crossJoin([], [], []));
+        $this->assertEmpty(Arr::crossJoin([], []));
+        $this->assertEmpty(Arr::crossJoin([]));
 
         // Not really a proper usage, still, test for preserving BC
         $this->assertSame([[]], Arr::crossJoin());
@@ -269,8 +269,8 @@ public function testGet()
         $this->assertSame('default', Arr::get(null, null, 'default'));
 
         // Test $array is empty and key is null
-        $this->assertSame([], Arr::get([], null));
-        $this->assertSame([], Arr::get([], null, 'default'));
+        $this->assertEmpty(Arr::get([], null));
+        $this->assertEmpty(Arr::get([], null, 'default'));
     }
 
     public function testHas()

tests/Support/SupportCollectionTest.php

@@ -123,10 +123,10 @@ public function testCollectionIsConstructed()
         $this->assertSame([false], $collection->all());
 
         $collection = new Collection(null);
-        $this->assertSame([], $collection->all());
+        $this->assertEmpty($collection->all());
 
         $collection = new Collection;
-        $this->assertSame([], $collection->all());
+        $this->assertEmpty($collection->all());
     }
 
     public function testGetArrayableItems()

tests/Support/SupportHelpersTest.php

@@ -124,7 +124,7 @@ public function testArrayOnly()
     {
         $array = ['name' => 'taylor', 'age' => 26];
         $this->assertEquals(['name' => 'taylor'], Arr::only($array, ['name']));
-        $this->assertSame([], Arr::only($array, ['nonExistingKey']));
+        $this->assertEmpty(Arr::only($array, ['nonExistingKey']));
     }
 
     public function testArrayCollapse()