feat(plugin_manager): optimize local plugin startup with concurrency (#375)

* feat(plugin_manager): optimize local plugin startup with concurrent control

- Add semaphore-based concurrency control for plugin launches
- Implement parallel plugin startup using goroutines
- Optimize error handling to prevent goroutine blocking
- Add concurrency metrics logging

Note: handleNewLocalPlugins now accepts config parameter with default concurrency limit

* feat(plugin_manager): make local plugin launching concurrency configurable

* fix(plugin_manager): optimize comment and error handling

- Updated comments to clarify the concurrent plugin launching configuration.
- Added a nil check for the error channel during plugin startup to improve code robustness.

* refactor(plugin_manager): refactor plugin startup logic

- Remove the semaphore mechanism and switch to using routine.Submit for concurrency management

* fix(plugin_manager): Optimize plugin startup logs and concurrency control

- Added log output for maximum concurrency when starting local plugins
- Implemented a channel-based concurrency control mechanism to ensure limits are not exceeded
- Fixed closure variable capture issue to prevent incorrect plugin information
- Improved error handling to avoid deadlocks during startup

* fix(plugin_manager): simplify error channel handling and semaphore release logic

---------

Co-authored-by: jim02.he <[email protected]>

Author: homejim

internal/core/plugin_manager/manager.go

@@ -74,8 +74,9 @@ func InitGlobalManager(oss oss.OSS, configuration *app.Config) *PluginManager {
 			configuration.PluginInstalledPath,
 		),
 		localPluginLaunchingLock: lock.NewGranularityLock(),
-		maxLaunchingLock:         make(chan bool, 2), // by default, we allow 2 plugins launching at the same time
-		config:                   configuration,
+		// By default, we allow up to configuration.PluginLocalLaunchingConcurrent plugins to be launched concurrently; if not configured, the default is 2.
+		maxLaunchingLock: make(chan bool, configuration.PluginLocalLaunchingConcurrent),
+		config:           configuration,
 	}
 
 	return manager
@@ -156,7 +157,7 @@ func (p *PluginManager) Launch(configuration *app.Config) {
 
 	// start local watcher
 	if configuration.Platform == app.PLATFORM_LOCAL {
-		p.startLocalWatcher()
+		p.startLocalWatcher(configuration)
 	}
 
 	// launch serverless connector

internal/core/plugin_manager/watcher.go

@@ -1,6 +1,7 @@
 package plugin_manager
 
 import (
+	"sync"
 	"time"
 
 	"github.com/langgenius/dify-plugin-daemon/internal/core/plugin_manager/debugging_runtime"
@@ -11,12 +12,13 @@ import (
 	"github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
 )
 
-func (p *PluginManager) startLocalWatcher() {
+func (p *PluginManager) startLocalWatcher(config *app.Config) {
 	go func() {
 		log.Info("start to handle new plugins in path: %s", p.config.PluginInstalledPath)
-		p.handleNewLocalPlugins()
+		log.Info("Launching plugins with max concurrency: %d", p.config.PluginLocalLaunchingConcurrent)
+		p.handleNewLocalPlugins(config)
 		for range time.NewTicker(time.Second * 30).C {
-			p.handleNewLocalPlugins()
+			p.handleNewLocalPlugins(config)
 			p.removeUninstalledLocalPlugins()
 		}
 	}()
@@ -66,34 +68,58 @@ func (p *PluginManager) startRemoteWatcher(config *app.Config) {
 	}
 }
 
-func (p *PluginManager) handleNewLocalPlugins() {
+func (p *PluginManager) handleNewLocalPlugins(config *app.Config) {
 	// walk through all plugins
 	plugins, err := p.installedBucket.List()
 	if err != nil {
 		log.Error("list installed plugins failed: %s", err.Error())
 		return
 	}
 
+	var wg sync.WaitGroup
+	maxConcurrency := config.PluginLocalLaunchingConcurrent
+	sem := make(chan struct{}, maxConcurrency)
+
 	for _, plugin := range plugins {
-		_, launchedChan, errChan, err := p.launchLocal(plugin)
-		if err != nil {
-			log.Error("launch local plugin failed: %s", err.Error())
-		}
+		wg.Add(1)
+		// Fix closure issue: create local variable copy
+		currentPlugin := plugin
+		routine.Submit(map[string]string{
+			"module":   "plugin_manager",
+			"function": "handleNewLocalPlugins",
+		}, func() {
+			// Acquire sem inside goroutine
+			sem <- struct{}{}
+			defer func() {
+				if err := recover(); err != nil {
+					log.Error("plugin launch runtime error: %v", err)
+				}
+				<-sem
+				wg.Done()
+			}()
 
-		// avoid receiving nil channel
-		if errChan != nil {
-			// consume error, avoid deadlock
-			for err := range errChan {
-				log.Error("plugin launch error: %s", err.Error())
+			_, launchedChan, errChan, err := p.launchLocal(currentPlugin)
+			if err != nil {
+				log.Error("launch local plugin failed: %s", err.Error())
+				return
 			}
-		}
 
-		// avoid receiving nil channel
-		if launchedChan != nil {
-			// wait for plugin launched
-			<-launchedChan
-		}
+			// Handle error channel
+			if errChan != nil {
+				for err := range errChan {
+					log.Error("plugin launch error: %s", err.Error())
+				}
+			}
+
+			// Wait for plugin to complete startup
+			if launchedChan != nil {
+				<-launchedChan
+			}
+		})
 	}
+
+	// wait for all plugins to be launched
+	wg.Wait()
 }
 
 // an async function to remove uninstalled local plugins