Remove some noqa: ARG rules escapes
#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
force-pushed
the
fix-ruff-arg
branch
from
68d5981 to
f026755
Compare
cbornet
changed the title
noqa: ARG rules escapes
cbornet
commented
Sep 30, 2024
| def test_astradb_vectorstore_vectorize_headers_precedence_stringheader( | ||
| self, | ||
| astra_db_credentials: AstraDBCredentials, | ||
| collection_vz: Collection, # noqa: ARG002 |
Collaborator
Author
There was a problem hiding this comment.
Injecting collection_vz had no use here ?
Collaborator
There was a problem hiding this comment.
Ah, I think you spotted a bug in testing (both here and in the subsequent test_astradb_vectorstore_vectorize_headers_precedence_headerprovider). Well done!
hemidactylus
approved these changes
Sep 30, 2024
Collaborator
hemidactylus
left a comment
hemidactylus
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning the noqas and also replacing the constants with <collection>.name !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #83