Accept None ids in AstraDBVectorStore.add_texts

Author: cbornet

libs/astradb/langchain_astradb/vectorstores.py

@@ -1451,10 +1451,12 @@ def _get_documents_to_insert(
         texts: Iterable[str],
         embedding_vectors: Sequence[list[float] | None],
         metadatas: list[dict] | None = None,
-        ids: list[str] | None = None,
+        ids: Iterable[str | None] | None = None,
     ) -> list[DocDict]:
         if ids is None:
-            ids = [uuid.uuid4().hex for _ in texts]
+            ids_ = [uuid.uuid4().hex for _ in texts]
+        else:
+            ids_ = [uuid.uuid4().hex if id_ is None else id_ for id_ in ids]
         if metadatas is None:
             metadatas = [{} for _ in texts]
         documents_to_insert = [
@@ -1467,7 +1469,7 @@ def _get_documents_to_insert(
             for b_txt, b_emb, b_id, b_md in zip(
                 texts,
                 embedding_vectors,
-                ids,
+                ids_,
                 metadatas,
                 strict=True,
             )
@@ -1483,7 +1485,7 @@ def add_texts(
         self,
         texts: Iterable[str],
         metadatas: list[dict] | None = None,
-        ids: list[str] | None = None,
+        ids: Iterable[str | None] | None = None,
         *,
         batch_size: int | None = None,
         batch_concurrency: int | None = None,
@@ -1624,7 +1626,7 @@ async def aadd_texts(
         self,
         texts: Iterable[str],
         metadatas: list[dict] | None = None,
-        ids: list[str] | None = None,
+        ids: Iterable[str | None] | None = None,
         *,
         batch_size: int | None = None,
         batch_concurrency: int | None = None,