Skip to content

Fix filenames to be windows compatible (remove *) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix filenames to be windows compatible (remove *) #168

wants to merge 3 commits into from

Conversation

@erik-wang-lancedb
Copy link
Contributor

@erik-wang-lancedb erik-wang-lancedb commented Nov 12, 2025 •
edited
Loading

Continuation of #113

Ran a shell script to change 1* in filenames to 1x, and change filenames of files with 1*... to 1x...

@vercel
Copy link

vercel bot commented Nov 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
blog-lancedb Ready Ready Preview Comment Nov 12, 2025 8:56pm

@erik-wang-lancedb erik-wang-lancedb marked this pull request as draft November 13, 2025 07:03
@erik-wang-lancedb
Copy link
Contributor Author

erik-wang-lancedb commented Nov 13, 2025

Need to fix script, links to external images have 1* that was also changed incorrectly

@prrao87
Copy link
Collaborator

prrao87 commented Nov 25, 2025

@erik-wang-lancedb is this still required as we migrate into the new docs? Not sure what the file name change accomplishes exactly 🤔.

@erik-wang-lancedb
Copy link
Contributor Author

erik-wang-lancedb commented Nov 26, 2025

I was thinking of putting this on hold until after migration. The issue is windows does not support the "*" character for filenames, so currently if you're on a windows machine and clone this repo, the clone will just fail.

This is an issue since many demos have code in this repo, thus if user wants to clone this repo to get the demo code it would fail (for users on windows).

There are of course workarounds such as using sparse checkout or wsl, but not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erik-wang-lancedb @prrao87