Skip to content

Apply PHP 7.4 syntax and typed property #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Apply PHP 7.4 syntax and typed property #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/ParameterNotFoundException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@

class ParameterNotFoundException extends InvalidArgumentException
{
/** @var string */
private $key;
private string $key;

public function __construct(string $message = "", int $code = 0, ?Throwable $previous = null, string $key = '')
{
Expand Down
4 changes: 2 additions & 2 deletions src/ParameterPostProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ParameterPostProcessor
* @var array<string,mixed>
* @psalm-var TParameters
*/
private $parameters;
private array $parameters;

/**
* @param array<string,mixed> $parameters
Expand All @@ -44,7 +44,7 @@ public function __invoke(array $config): array
$parameters = $this->getResolvedParameters();

/** @psalm-suppress MissingClosureParamType */
array_walk_recursive($config, static function (&$value) use ($parameters) {
array_walk_recursive($config, static function (&$value) use ($parameters): void {
/** @psalm-suppress MixedAssignment */
$value = $parameters->unescapeValue($parameters->resolveValue($value));
});
Expand Down
4 changes: 1 addition & 3 deletions test/LazyParameterPostProcessorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ public function testParameterProviderNotCalledDuringInstantiation(): void

public function testParametersAreBeingProcessed(): void
{
$provider = static function (): array {
return ['foo' => 'bar'];
};
$provider = static fn(): array => ['foo' => 'bar'];

$config = [
'foo' => '%foo%',
Expand Down