From a33c1f28d75f0b7dc9a11912401d033275acad85 Mon Sep 17 00:00:00 2001 From: Pablo Deymonnaz Date: Mon, 3 Nov 2025 13:03:08 -0300 Subject: [PATCH 1/4] tuning parameters of qfilter --- crates/storage/trie_db/layering.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/storage/trie_db/layering.rs b/crates/storage/trie_db/layering.rs index 75d67757f38..ae52f3b7294 100644 --- a/crates/storage/trie_db/layering.rs +++ b/crates/storage/trie_db/layering.rs @@ -44,7 +44,7 @@ impl Default for TrieLayerCache { impl TrieLayerCache { // TODO: tune this fn create_filter() -> Result { - qfilter::Filter::new_resizeable(100_000, 100_000_000, 0.02) + qfilter::Filter::new_resizeable(1_000_000, 100_000_000, 0.02) .inspect_err(|e| tracing::warn!("could not create trie layering bloom filter {e}")) } From 687dccfb14290cd0d35c501feac8ddae4409de05 Mon Sep 17 00:00:00 2001 From: Javier Chatruc Date: Mon, 3 Nov 2025 15:47:35 -0300 Subject: [PATCH 2/4] Test going back to previous value to see if CI still fails --- crates/storage/trie_db/layering.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/storage/trie_db/layering.rs b/crates/storage/trie_db/layering.rs index ae52f3b7294..75d67757f38 100644 --- a/crates/storage/trie_db/layering.rs +++ b/crates/storage/trie_db/layering.rs @@ -44,7 +44,7 @@ impl Default for TrieLayerCache { impl TrieLayerCache { // TODO: tune this fn create_filter() -> Result { - qfilter::Filter::new_resizeable(1_000_000, 100_000_000, 0.02) + qfilter::Filter::new_resizeable(100_000, 100_000_000, 0.02) .inspect_err(|e| tracing::warn!("could not create trie layering bloom filter {e}")) } From 4e2912da3062d7ea833b225999e8d07c57cf1e3e Mon Sep 17 00:00:00 2001 From: Javier Chatruc Date: Mon, 3 Nov 2025 15:52:18 -0300 Subject: [PATCH 3/4] Introduce artificial change to trigger CI --- crates/storage/trie_db/layering.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/storage/trie_db/layering.rs b/crates/storage/trie_db/layering.rs index 75d67757f38..09eb9b4de4c 100644 --- a/crates/storage/trie_db/layering.rs +++ b/crates/storage/trie_db/layering.rs @@ -47,6 +47,7 @@ impl TrieLayerCache { qfilter::Filter::new_resizeable(100_000, 100_000_000, 0.02) .inspect_err(|e| tracing::warn!("could not create trie layering bloom filter {e}")) } + // Test pub fn get(&self, state_root: H256, key: Nibbles) -> Option> { let key = key.as_ref(); From b74b564545062b1503d90b51abdc323949c4147c Mon Sep 17 00:00:00 2001 From: Javier Chatruc Date: Mon, 3 Nov 2025 16:06:06 -0300 Subject: [PATCH 4/4] Undo changes --- crates/storage/trie_db/layering.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/crates/storage/trie_db/layering.rs b/crates/storage/trie_db/layering.rs index 09eb9b4de4c..ae52f3b7294 100644 --- a/crates/storage/trie_db/layering.rs +++ b/crates/storage/trie_db/layering.rs @@ -44,10 +44,9 @@ impl Default for TrieLayerCache { impl TrieLayerCache { // TODO: tune this fn create_filter() -> Result { - qfilter::Filter::new_resizeable(100_000, 100_000_000, 0.02) + qfilter::Filter::new_resizeable(1_000_000, 100_000_000, 0.02) .inspect_err(|e| tracing::warn!("could not create trie layering bloom filter {e}")) } - // Test pub fn get(&self, state_root: H256, key: Nibbles) -> Option> { let key = key.as_ref();