From 786b95b798951d6c028b75573bfad232fcb0d839 Mon Sep 17 00:00:00 2001 From: fmoletta Date: Mon, 20 Oct 2025 15:30:26 -0300 Subject: [PATCH 1/2] fix(l1): track requested pooled transactions --- crates/networking/p2p/rlpx/connection/server.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/networking/p2p/rlpx/connection/server.rs b/crates/networking/p2p/rlpx/connection/server.rs index d6486c6460b..8631cf1c6b2 100644 --- a/crates/networking/p2p/rlpx/connection/server.rs +++ b/crates/networking/p2p/rlpx/connection/server.rs @@ -992,8 +992,10 @@ async fn handle_incoming_message( Message::NewPooledTransactionHashes(new_pooled_transaction_hashes) if peer_supports_eth => { let hashes = new_pooled_transaction_hashes.get_transactions_to_request(&state.blockchain)?; - let request = GetPooledTransactions::new(random(), hashes); + state + .requested_pooled_txs + .insert(request.id, new_pooled_transaction_hashes); send(state, Message::GetPooledTransactions(request)).await?; } Message::GetPooledTransactions(msg) => { From 91700e8919c84ce9236f534f32dfe92f09f86792 Mon Sep 17 00:00:00 2001 From: fmoletta Date: Mon, 20 Oct 2025 15:36:18 -0300 Subject: [PATCH 2/2] Re-enable hive p2p test eth/BlobViolations --- .github/workflows/pr-main_l1.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-main_l1.yaml b/.github/workflows/pr-main_l1.yaml index 8174cd42c25..70a5ab220c0 100644 --- a/.github/workflows/pr-main_l1.yaml +++ b/.github/workflows/pr-main_l1.yaml @@ -150,7 +150,7 @@ jobs: artifact_prefix: rpc_compat - name: "Devp2p tests" simulation: devp2p - limit: discv4|eth|snap/Ping|Findnode/WithoutEndpointProof|Findnode/PastExpiration|Amplification|Status|StorageRanges|ByteCodes|GetBlockHeaders|SimultaneousRequests|SameRequestID|ZeroRequestID|GetBlockBodies|MaliciousHandshake|MaliciousStatus|NewPooledTxs|GetBlockReceipts|BlockRangeUpdate|GetTrieNodes + limit: discv4|eth|snap/Ping|Findnode/WithoutEndpointProof|Findnode/PastExpiration|Amplification|Status|StorageRanges|ByteCodes|GetBlockHeaders|SimultaneousRequests|SameRequestID|ZeroRequestID|GetBlockBodies|MaliciousHandshake|MaliciousStatus|NewPooledTxs|GetBlockReceipts|BlockRangeUpdate|GetTrieNodes|BlobViolations # Findnode/BasicFindnode fails due to packets being processed out of order # Findnode/UnsolicitedNeighbors flaky in CI very occasionally. When fixed replace all "Findnode/" with "Findnode" artifact_prefix: devp2p