Commit 5bbfc65
feat(l1): upgrade execution breakdown pie chart and add new panels (#5220)
**Motivation**
We needed more granular panels to analyze the breakdown of execution for
performance decisions.
**Description**
This PR use the current instrumentation to:
- Update the pie char of execution
- Add a diff measurement between execution and merkleization to
understand the work of the `execute_block_pipeline` function
- Add a deagregated series by block showing the different
instrumentations available today
- Maintain all of them in the previous Block Execution Breakdown row and
repeat them vertically across instances
<img width="1910" height="705" alt="image"
src="https://github.com/user-attachments/assets/0af6dfda-41b3-46f0-8463-1494c6ea0c8b"
/>
**Note for running it locally:**
_After #5088 we needed to re-labeling our local instances to avoid
duplicated panels that repeat across instances. This requires prometheus
to be restarted to pick up the new labeling, one way to check this out
is make look at intances, if `ethereum-metrics-exporte` appears there,
we need to restart prometheus, only `localhost` should be there
locally._
| Bad (needs restarting prometheus)| Good |
| --- | --- |
| <img width="359" height="156" alt="image"
src="https://github.com/user-attachments/assets/7c4bfd32-f565-4a79-bea9-86094128bfcf"
/> | <img width="453" height="176" alt="image"
src="https://github.com/user-attachments/assets/8e8423ec-3830-461f-94ab-697bd5967968"
/> |
**Next steps:**
- Naming is not optimal, but changing it would require breaking the
panel for instances not updated to this PR. We want first to test it
with all instances and make sure the panels are useful and change the
names afterwards, here is an issue for tracking that: #5219
Closes #5218
---------
Co-authored-by: Copilot <[email protected]>1 parent ee07397 commit 5bbfc65
File tree
5 files changed
+429
-106
lines changed- crates
- blockchain
- storage
- store_db
- vm/backends
- metrics/provisioning/grafana/dashboards/common_dashboards
5 files changed
+429
-106
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
792 | 792 | | |
793 | 793 | | |
794 | 794 | | |
| 795 | + | |
795 | 796 | | |
796 | 797 | | |
797 | 798 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
352 | 352 | | |
353 | 353 | | |
354 | 354 | | |
355 | | - | |
356 | 355 | | |
357 | 356 | | |
358 | 357 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
808 | 808 | | |
809 | 809 | | |
810 | 810 | | |
811 | | - | |
812 | | - | |
813 | 811 | | |
814 | 812 | | |
815 | 813 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | 76 | | |
78 | 77 | | |
79 | 78 | | |
| |||
0 commit comments