Destroy queue before device #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Aug 31, 2024
Owner
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
this isn't actually destroying the queue before anything
queue isn't being destroyed in Vulkan
but it fixes the order of destruction for the queue semaphores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: zed-industries/zed#17005
Right now, the device is being destroyed before the queue. This causes crashes at least on Wayland (both in Zed and the examples in this repo).
There are still some Vulkan validation errors related to objects not being destroyed, but it's not crashing anymore at least 😅