Skip to content

Conversation

@shaneutt
Copy link
Member

This adds needs-triage and needs-priority for Gateway API, and also enables a couple of plugins including the cherrypicker.

Intends to resolve kubernetes-sigs/gateway-api#1800

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2023
@shaneutt
Copy link
Member Author

/cc @robscott
/cc @youngnick

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Apr 11, 2023
@shaneutt shaneutt force-pushed the shaneutt/plugins-for-gateway-api-2023-04-11 branch from 2637219 to 00a7ec3 Compare April 11, 2023 13:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2023
@shaneutt shaneutt marked this pull request as ready for review April 11, 2023 13:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from chases2 April 11, 2023 13:49
@robscott
Copy link
Member

Thanks @shaneutt!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@shaneutt
Copy link
Member Author

shaneutt commented May 2, 2023

Heya 👋 just checking in?

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1745516 into kubernetes:master May 15, 2023
@k8s-ci-robot
Copy link
Contributor

@shaneutt: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

This adds needs-triage and needs-priority for Gateway API, and also enables a couple of plugins including the cherrypicker.

Intends to resolve kubernetes-sigs/gateway-api#1800

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaneutt shaneutt deleted the shaneutt/plugins-for-gateway-api-2023-04-11 branch May 16, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triage for issues, cherry picking, and other plugins

4 participants