diff --git a/api/types/kustomization.go b/api/types/kustomization.go index 41376bedd4..f86ec0b9e2 100644 --- a/api/types/kustomization.go +++ b/api/types/kustomization.go @@ -188,6 +188,7 @@ const ( deprecatedPatchesJson6902Message = "# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix deprecatedPatchesStrategicMergeMessage = "# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix deprecatedVarsMessage = "# Warning: 'vars' is deprecated. Please use 'replacements' instead." + " " + deprecatedWarningToRunEditFixExperimential + deprecatedCommonLabelsWarningMessage = "# Warning: 'commonLabels' is deprecated. Please use 'labels' instead." + " " + deprecatedWarningToRunEditFix ) // CheckDeprecatedFields check deprecated field is used or not. @@ -196,6 +197,9 @@ func (k *Kustomization) CheckDeprecatedFields() *[]string { if k.Bases != nil { warningMessages = append(warningMessages, deprecatedBaseWarningMessage) } + if k.CommonLabels != nil { + warningMessages = append(warningMessages, deprecatedCommonLabelsWarningMessage) + } if k.ImageTags != nil { warningMessages = append(warningMessages, deprecatedImageTagsWarningMessage) } diff --git a/api/types/kustomization_test.go b/api/types/kustomization_test.go index 963f774f66..f39455f7ec 100644 --- a/api/types/kustomization_test.go +++ b/api/types/kustomization_test.go @@ -29,6 +29,13 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) { }, want: &[]string{deprecatedBaseWarningMessage}, }, + { + name: "using_CommonLabels", + k: Kustomization{ + CommonLabels: map[string]string{}, + }, + want: &[]string{deprecatedCommonLabelsWarningMessage}, + }, { name: "using_ImageTags", k: Kustomization{ @@ -61,6 +68,7 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) { name: "usingAll", k: Kustomization{ Bases: []string{"base"}, + CommonLabels: map[string]string{}, ImageTags: []Image{}, PatchesJson6902: []Patch{}, PatchesStrategicMerge: []PatchStrategicMerge{}, @@ -68,6 +76,7 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) { }, want: &[]string{ deprecatedBaseWarningMessage, + deprecatedCommonLabelsWarningMessage, deprecatedImageTagsWarningMessage, deprecatedPatchesJson6902Message, deprecatedPatchesStrategicMergeMessage,