🌱 (fix): Fix inconsistent logging format ( Follow up: #4968 ) #5044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Follow up: kubernetes-sigs#4968 Testing alpha update and generate revealed logs were not in the right format. Changes: - Initialize consistent logging handler in alpha commands to fix level=info msg= format - Replace log.Fatalf with slog.Error + os.Exit(1) for proper error handling - Standardize log imports to use log "log/slog" across all files - Remove redundant command info from RunCmd logging output - Ensure all kubebuilder processes use the same colored INFO/WARN format Before: level=warning msg="Using current working directory..." After: WARN Using current working directory... Assisted-by: Cursor
camilamacedo86
force-pushed
the
fix-logs-alpha-commands-cli
branch
from
8ce27dc to
8aca76b
Compare
camilamacedo86
added
the
lgtm
Member
Author
|
Moving forward since it is a small fix |
camilamacedo86
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fix): Fix inconsistent logging format
Follow up: #4968
Testing alpha update and generate revealed logs were not in the right format.
Changes:
Before: level=warning msg="Using current working directory..."
After: WARN Using current working directory...