Fixing the image references in the bundle samples. #1197
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for kubernetes-sigs-kmm failed. Why did it fail? →
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Contributor
Author
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
- Coverage 79.09% 73.65% -5.45%
==========================================
Files 51 66 +15
Lines 5109 4566 -543
==========================================
- Hits 4041 3363 -678
- Misses 882 1041 +159
+ Partials 186 162 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When building the bundle locally we usually use `make bundle` but when building it in cloudbuild for publishing in operatorhub.io, we use `make bundle ... USE_IMAGEDIGESTS=true` which will eventually generate the manifests and run `operator-sdk generate bundle ... --use-image-digests`. While the main purpose of this flag is to refer all images by digest, it also, as a side effect, pull those images to discover their digest. Since we are using dummy images in the CSV samples, with a "real" image URL, operator-sdk treats those as actual pullable images, and tries to pull them to discover their digest. This commit is changing the dummy images with a "place holder description" instead of a valuable URL to prevent `operator-sdk` treating those as real images. Signed-off-by: Yoni Bettan <[email protected]>
ybettan
force-pushed
the
fixing-bundle
branch
3 times, most recently
from
8bde4de to
a5bcbfc
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the bundle locally we usually use
make bundlebut when building it in cloudbuild for publishing in operatorhub.io, we usemake bundle ... USE_IMAGEDIGESTS=truewhich will eventually generate the manifests and runoperator-sdk generate bundle ... --use-image-digests.While the main purpose of this flag is to refer all images by digest, it also, as a side effect, pull those images to discover their digest.
Since we are using dummy images in the CSV samples, with a "real" image URL, operator-sdk treats those as actual pullable images, and tries to pull them to discover their digest.
This commit is changing the dummy images with a "place holder description" instead of a valuable URL to prevent
operator-sdktreating those as real images./assign @TomerNewman @yevgeny-shnaidman
Cloudbuilds are filing for ~2 months now.