Skip to content

Commit 3d1d087

Browse files
committed
Fixing the image references in the bundle samples.
When building the bundle locally we usually use `make bundle` but when building it in cloudbuild for publishing in operatorhub.io, we use `make bundle ... USE_IMAGEDIGESTS=true` which will eventually generate the manifests and run `operator-sdk generate bundle ... --use-image-digests`. While the main purpose of this flag is to refer all images by digest, it also, as a side effect, pull those images to discover their digest. Since we are using dummy images in the CSV samples, with a "real" image URL, operator-sdk treats those as actual pullable images, and tries to pull them to discover their digest. This commit is changing the dummy images with a "place holder description" instead of a valuable URL to prevent `operator-sdk` treating those as real images. Signed-off-by: Yoni Bettan <[email protected]>
1 parent a7509a1 commit 3d1d087

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

config/samples/kmm.sigs.x-k8s.io_modulebuildsignconfigs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ metadata:
44
name: modulebuildsignconfig-sample
55
spec:
66
images:
7-
- image: quay.io/myorg/my-kernel-module:latest
7+
- image: <kmod container image URL>
88
kernelVersion: 4.18.0-372.32.1.el8_6.x86_64
99
action: BuildImage
1010
build:

config/samples/kmm.sigs.x-k8s.io_moduleimagesconfigs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ metadata:
44
name: moduleimagesconfig-sample
55
spec:
66
images:
7-
- image: quay.io/myorg/my-kernel-module:v1.0.0
7+
- image: <kmod container image URL>
88
kernelVersion: 4.18.0-372.32.1.el8_6.x86_64
99
imagePullPolicy: IfNotPresent
1010
pushBuiltImage: false

config/samples/kmm.sigs.x-k8s.io_nodemodulesconfigs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ spec:
99
serviceAccountName: kmm-operator-controller
1010
config:
1111
kernelVersion: 4.18.0-372.32.1.el8_6.x86_64
12-
containerImage: quay.io/myorg/my-kernel-module:latest
12+
containerImage: <kmod container image URL>
1313
imagePullPolicy: IfNotPresent
1414
insecurePull: false
1515
modprobe:

0 commit comments

Comments
 (0)