Add Docker build and push workflows for PRs and releases#97
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wangchen615 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR automates Docker image publishing for both PR merges and release events by adding workflows that build and push Docker images to quay.io/inference‑perf.
- Added a new workflow (.github/workflows/docker-build.yml) to trigger a Docker build and push when a PR is merged into main.
- Updated the release workflow (.github/workflows/release.yml) to include a Docker job that builds and pushes an image tagged with the release version and "latest".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Added a Docker job to build and push images following a release. |
| .github/workflows/docker-build.yml | Introduced a workflow to trigger Docker image build/push on PR merges to main. |
Co-authored-by: Copilot <[email protected]>
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements automated Docker image publishing (to quay.io/inference-perf) for both PR merges and releases.
In detail, the changes include:
Required Secrets:
QUAY_USERNAME (your quay.io username)
QUAY_PASSWORD (your quay.io password or token)
Testing:
[x] Verified that the Docker image builds successfully (and is amd64).
[x] Tested locally (using Podman).
[x] (Note: The quay.io repository (quay.io/inference‑perf) must be created before the first push.)
Pull this container with the following Docker command:
Closes #85