Skip to content

Add ShareGPT end-to-end tests#414

Merged
jjk-g merged 2 commits into
kubernetes-sigs:mainfrom
diamondburned:sharegpt-e2e
Apr 6, 2026
Merged

Add ShareGPT end-to-end tests#414
jjk-g merged 2 commits into
kubernetes-sigs:mainfrom
diamondburned:sharegpt-e2e

Conversation

@diamondburned
Copy link
Copy Markdown
Contributor

This improves our end-to-end test coverage a bit more.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2026
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 6, 2026
@diamondburned
Copy link
Copy Markdown
Contributor Author

diamondburned commented Apr 6, 2026

Details on the include_usage change:

@jjk-g
Copy link
Copy Markdown
Collaborator

jjk-g commented Apr 6, 2026

/lgtm
/approve

@jjk-g jjk-g merged commit 1c587bd into kubernetes-sigs:main Apr 6, 2026
5 of 6 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diamondburned, jjk-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026
@diamondburned diamondburned deleted the sharegpt-e2e branch April 6, 2026 23:29
jjk-g pushed a commit to jjk-g/inference-perf that referenced this pull request Apr 30, 2026
This improves our end-to-end test coverage a bit more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants