Skip to content

Add shuffle to multi-round prompt generation#331

Merged
jjk-g merged 1 commit into
kubernetes-sigs:mainfrom
elevran:multiround_shuffle
Feb 5, 2026
Merged

Add shuffle to multi-round prompt generation#331
jjk-g merged 1 commit into
kubernetes-sigs:mainfrom
elevran:multiround_shuffle

Conversation

@elevran
Copy link
Copy Markdown
Contributor

@elevran elevran commented Jan 29, 2026

Fixes #324

Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2026
@jjk-g
Copy link
Copy Markdown
Collaborator

jjk-g commented Jan 29, 2026

/lgtm
/approve

@huaxig to add issue to 1.0.0 for test covering this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elevran, jjk-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2026
@elevran elevran mentioned this pull request Jan 30, 2026
bongwoobak added a commit to moreh-dev/inference-perf that referenced this pull request Feb 4, 2026
Also revert shuffle synchronization to match origin/main - only shuffle
prompts list. Shuffle synchronization for prompt_pairs and user_sessions
will be handled separately in PR kubernetes-sigs#331.
@jjk-g jjk-g merged commit f44117a into kubernetes-sigs:main Feb 5, 2026
4 of 5 checks passed
bongwoobak added a commit to moreh-dev/inference-perf that referenced this pull request Feb 19, 2026
Also revert shuffle synchronization to match origin/main - only shuffle
prompts list. Shuffle synchronization for prompt_pairs and user_sessions
will be handled separately in PR kubernetes-sigs#331.
bongwoobak added a commit to moreh-dev/inference-perf that referenced this pull request Feb 25, 2026
Also revert shuffle synchronization to match origin/main - only shuffle
prompts list. Shuffle synchronization for prompt_pairs and user_sessions
will be handled separately in PR kubernetes-sigs#331.
hhk7734 pushed a commit to moreh-dev/inference-perf that referenced this pull request Apr 23, 2026
Also revert shuffle synchronization to match origin/main - only shuffle
prompts list. Shuffle synchronization for prompt_pairs and user_sessions
will be handled separately in PR kubernetes-sigs#331.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No shuffling of system prompt when using shared_prefix with multi round

3 participants