Skip to content

fix(config): substitute timestamp in storage paths#330

Merged
jjk-g merged 2 commits into
kubernetes-sigs:mainfrom
yangligt2:fix/storage-timestamp-substitution
Apr 2, 2026
Merged

fix(config): substitute timestamp in storage paths#330
jjk-g merged 2 commits into
kubernetes-sigs:mainfrom
yangligt2:fix/storage-timestamp-substitution

Conversation

@yangligt2
Copy link
Copy Markdown
Contributor

fixes #329

Updated inference_perf/config.py to detect and replace {timestamp} with the current time (format: %Y%m%d-%H%M%S) in storage paths for local_storage, google_cloud_storage, and simple_storage_service.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @yangligt2!

It looks like this is your first PR to kubernetes-sigs/inference-perf 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/inference-perf has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2026
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2026
@Bslabe123
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2026
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 5, 2026
@jjk-g
Copy link
Copy Markdown
Collaborator

jjk-g commented Mar 5, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjk-g, yangligt2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@jjk-g jjk-g merged commit ff0b523 into kubernetes-sigs:main Apr 2, 2026
5 of 6 checks passed
jjk-g added a commit to jjk-g/inference-perf that referenced this pull request Apr 30, 2026
fixes kubernetes-sigs#329 

Updated inference_perf/config.py to detect and replace {timestamp} with
the current time (format: %Y%m%d-%H%M%S) in storage paths for
local_storage, google_cloud_storage, and simple_storage_service.

Co-authored-by: Jason Kramberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support {timestamp} substitution in storage config paths

4 participants