Skip to content

fix pyproject dependency groups and TOML parsing issue#291

Merged
jjk-g merged 1 commit into
kubernetes-sigs:mainfrom
diamondburned:pyproject-fix
Nov 25, 2025
Merged

fix pyproject dependency groups and TOML parsing issue#291
jjk-g merged 1 commit into
kubernetes-sigs:mainfrom
diamondburned:pyproject-fix

Conversation

@diamondburned
Copy link
Copy Markdown
Contributor

This commit rearranges some dependencies in pyproject to be in their appropriate dependency groups (test, types) rather than in the main list.

Also fixed minor TOML formatting issue that caused a C++ TOML parser to fail at tool.mypy:

error: while parsing TOML: [error] toml::insert_value: table ("tool.mypy") already exists.
 --> fromTOML
     |
 126 | [[tool.mypy.overrides]]
     | ~~~~~~~~~~~~~~~~~~~~~~~ table already exists here
 ...
 134 | [tool.mypy]
     | ~~~~~~~~~~~ table defined twice

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2025
This commit rearranges some dependencies in pyproject to be in their
appropriate dependency groups (test, types) rather than in the main
list.

Also fixed minor TOML formatting issue that caused a C++ TOML parser to
fail at `tool.mypy`.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2025
@jjk-g
Copy link
Copy Markdown
Collaborator

jjk-g commented Nov 25, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diamondburned, jjk-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jjk-g jjk-g merged commit 9cc3b96 into kubernetes-sigs:main Nov 25, 2025
4 of 5 checks passed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants