Defer InferenceAPIData gen to worker procs#157
Merged
Conversation
Currently worker 0 queues all request data upfront via yield. Significant perf improvement defering the generation of data to the worker procs. This refactors each worker to have their own datagen instance and requires generating the request per request number.
a7a05c5 to
232e560
Compare
Collaborator
Author
|
With latest changes hit nearly 20k qps (w/ some client side errors) against an instantaneous echo server. |
Collaborator
Author
|
Testing against llama3-8b model server |
Collaborator
Author
|
sharegpt: |
Collaborator
Author
|
Added future thoughts on testing in #40 |
Add uvloop as drop in replacement for asyncio event loop Fix timer to more reliably hit specified duration Add sleep to reduce CPU contention of queue polling
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achandrasekar, jjk-g The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loadgen architecture performance improvements (and qps accuracy improvements).
Achieves > 10k qps in some cases (large machine, random/synthetic/shared_prefix datasets, low request latency).
Improved schedule accuracy in low qps scenarios.
Fixes #188
Changes
Future Recommendations
Testing Done
Later comments show acceptable scheduling accuracy conformance for:
Also profiling and vllm metric comparison in #188