Skip to content

Add detection for model_name and tokenizer#145

Merged
SachinVarghese merged 1 commit into
kubernetes-sigs:mainfrom
jjk-g:infer_config
Jul 17, 2025
Merged

Add detection for model_name and tokenizer#145
SachinVarghese merged 1 commit into
kubernetes-sigs:mainfrom
jjk-g:infer_config

Conversation

@jjk-g
Copy link
Copy Markdown
Collaborator

@jjk-g jjk-g commented Jul 14, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 14, 2025
Comment thread inference_perf/config.py
@jjk-g jjk-g force-pushed the infer_config branch 2 times, most recently from e5ae65d to 090ab69 Compare July 14, 2025 22:58
Copy link
Copy Markdown
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor update requested.

Comment thread inference_perf/client/modelserver/vllm_client.py
Copy link
Copy Markdown
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjk-g, SachinVarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@SachinVarghese SachinVarghese merged commit 5baeee4 into kubernetes-sigs:main Jul 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants