fix: improve Docker build workflow with better secret handling and debugging#128
Merged
achandrasekar merged 2 commits intoJun 26, 2025
Merged
Conversation
…bugging - Remove docker/metadata-action to avoid secret substitution issues - Set image name and tags as environment variables first - Add comprehensive debugging output for environment variables - Directly specify Docker tags and labels in build action - Add validation and debug steps for better troubleshooting
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wangchen615 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Docker build workflow by addressing secret handling and debugging issues.
- Removed the usage of docker/metadata-action@v5 to prevent secret substitution problems
- Introduced environment variable setup and comprehensive debugging output
- Updated tag and label specifications directly in the build action
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:60
- Consider adding a sanitization step or validation for TAG_VERSION to ensure it complies with Docker tag naming conventions.
echo "TAG_VERSION=${{ github.ref_name }}" >> $GITHUB_ENV
Co-authored-by: Copilot <[email protected]>
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
wangchen615
added a commit
that referenced
this pull request
Jun 26, 2025
…bugging (#128) ## Changes This PR fixes the Docker build workflow issue where the image tag was showing as 'quay.io/***/inference-perf' instead of the proper username. ### Key Changes: - Remove `docker/metadata-action@v5` to avoid secret substitution issues - Set image name and tags as environment variables first, then use them directly - Add comprehensive debugging output for environment variables - Directly specify Docker tags and labels in build action - Add validation and debug steps for better troubleshooting ### Testing: - The workflow now shows all environment variables for debugging - Docker tags are constructed directly from environment variables - This should resolve the 'invalid reference format' error ### Related Issue: Fixes the Docker build error: 'invalid tag \"quay.io/***/inference-perf:v0.1.0\": invalid reference format'" Fix #119 --------- Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the Docker build workflow issue where the image tag was showing as 'quay.io/***/inference-perf' instead of the proper username.
Key Changes:
docker/metadata-action@v5to avoid secret substitution issuesTesting:
Related Issue:
Fixes the Docker build error: 'invalid tag "quay.io/***/inference-perf:v0.1.0": invalid reference format'"
Fix #119