Skip to content

Conversation

@robscott
Copy link
Member

@robscott robscott commented Oct 13, 2023

What type of PR is this?
/kind cleanup
/kind feature

What this PR does / why we need it:
In prepration for v1.0.0-rc1 (see #2482), this adds v1 types for Gateway, GatewayClass, and HTTPRoute. This also switches over conformance tests to make use of them.

A few notes:

  • Conformance tests have all changed to use v1 API versions where available
  • Examples are mostly still v1beta1 since they're used in docs, bumped some that were not used in docs, rest will have to wait until after v1.0 is released
  • Storage version stays at v1beta1, will get bumped in next minor release
  • Continue to recommend that implementations read and write from v1beta1 to support a broader range of GW API versions
  • v1alpha2 versions of Gateway, GatewayClass, and HTTPRoute have all gone from "unserved" to "skipped". That means they are no longer part of the CRD at all. Will plan to remove v1alpha2 types in next minor release. Note that this makes the CRD diff look like v1alpha2 was renamed to v1.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2023
@robscott
Copy link
Member Author

This is a massive PR, want to make sure we've got everything in order before merging.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@robscott robscott added this to the v1.0.0 milestone Oct 13, 2023
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaking this approach will lose the commit history for these files, and people's attribution. It should be possible to do some git tricks to copy the file in a way that it will continue tracking its history and attribution. One example of how this can be accomplished: https://stackoverflow.com/questions/16937359/git-copy-file-preserving-history

@robscott
Copy link
Member Author

@shaneutt I've spent some time looking into this, but I'm not sure that I'll have time to resolve this today. There's a lot of nuance and complexity in this PR, and the steps to maintain git history here seem unfortunately complex. For what it's worth, we did not maintain git history when transitioning from v1alpha2 -> v1beta1, and I can't find any examples of maintaining history for similar transitions between API versions in upstream Kubernetes. So although I agree that this would be nice to have, I personally don't think it should block this change (and corresponding release candidate).

@youngnick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@robscott
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0eee646 into kubernetes-sigs:main Oct 16, 2023
arkodg pushed a commit to arkodg/gateway-api that referenced this pull request Oct 18, 2023
ReferenceGrant's version was moved to `v1` as a mistake in
the conformance test YAML

Relates to kubernetes-sigs#2486

Signed-off-by: Arko Dasgupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants