-
Notifications
You must be signed in to change notification settings - Fork 621
Adding v1 types for Gateway, GatewayClass, and HTTPRoute #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is a massive PR, want to make sure we've got everything in order before merging. /hold |
shaneutt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaking this approach will lose the commit history for these files, and people's attribution. It should be possible to do some git tricks to copy the file in a way that it will continue tracking its history and attribution. One example of how this can be accomplished: https://stackoverflow.com/questions/16937359/git-copy-file-preserving-history
|
@shaneutt I've spent some time looking into this, but I'm not sure that I'll have time to resolve this today. There's a lot of nuance and complexity in this PR, and the steps to maintain git history here seem unfortunately complex. For what it's worth, we did not maintain git history when transitioning from v1alpha2 -> v1beta1, and I can't find any examples of maintaining history for similar transitions between API versions in upstream Kubernetes. So although I agree that this would be nice to have, I personally don't think it should block this change (and corresponding release candidate). |
|
/lgtm |
|
/hold cancel |
ReferenceGrant's version was moved to `v1` as a mistake in the conformance test YAML Relates to kubernetes-sigs#2486 Signed-off-by: Arko Dasgupta <[email protected]>
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
In prepration for v1.0.0-rc1 (see #2482), this adds v1 types for Gateway, GatewayClass, and HTTPRoute. This also switches over conformance tests to make use of them.
A few notes:
Does this PR introduce a user-facing change?: