Add conformance for multiple mirror filters #2359

levikobi · 2023-08-28T15:17:30Z

What type of PR is this?

/kind test
/area conformance

What this PR does / why we need it:
Adds a conformance test for multiple mirror filters within the same rule, tested using Contour's implementation.

Which issue(s) this PR fixes:

Fixes #2210

Does this PR introduce a user-facing change?:

None

LiorLieberman

Thats a great PR, thanks @levikobi !

conformance/utils/http/mirror.go

conformance/utils/suite/features.go

conformance/tests/httproute-request-multiple-mirrors.go

conformance/utils/http/mirror.go

conformance/tests/httproute-request-multiple-mirrors.yaml

conformance/tests/httproute-request-multiple-mirrors.go

LiorLieberman · 2023-08-28T20:07:29Z

conformance/tests/httproute-request-multiple-mirrors.go

+				Backend: "infra-backend-v1",
+				MirroredTo: []http.BackendRef{
+					{
+						Name:      "infra-backend-v2",
+						Namespace: ns,
+					},
+					{
+						Name:      "infra-backend-v3",
+						Namespace: "another-namespace",
+					},
+				},
+				Namespace: ns,


Not a requirement for this PR, but I am curious if changing Backend to the new BackendRef struct you created is something we want and how much effort it will take (since it is widely used in a lot of tests).

Well, if there is a demand for it I can address it in a follow-up PR

would be good if you can do a quick check and see if its something we would want and if so, open an issue for it (it can be a good-first-issue imo)

LiorLieberman · 2023-08-28T20:12:31Z

gateway-api/conformance/utils/suite/features.go

Lines 126 to 136 in 4f8e572

    
           var HTTPRouteExtendedFeatures = sets.New( 
        
           	SupportHTTPRouteQueryParamMatching, 
        
           	SupportHTTPRouteMethodMatching, 
        
           	SupportHTTPResponseHeaderModification, 
        
           	SupportHTTPRoutePortRedirect, 
        
           	SupportHTTPRouteSchemeRedirect, 
        
           	SupportHTTPRoutePathRedirect, 
        
           	SupportHTTPRouteHostRewrite, 
        
           	SupportHTTPRoutePathRewrite, 
        
           	SupportHTTPRouteRequestMirror, 
        
           )

Also you probably want to add the new supported feature here

Co-authored-by: Lior Lieberman <[email protected]>

levikobi · 2023-08-29T04:39:39Z

Thanks for the review @LiorLieberman!

LiorLieberman

Thanks @levikobi !
/lgtm

conformance/utils/http/mirror.go

LiorLieberman · 2023-08-30T07:19:22Z

/assign @shaneutt

Co-authored-by: Lior Lieberman <[email protected]>

LiorLieberman · 2023-08-30T16:48:45Z

/lgtm

robscott · 2023-09-05T17:18:27Z

/cc @sunjayBhatia @mlavacca @arkodg

robscott · 2023-09-05T17:18:53Z

This LGTM, but would like one of the conformance approvers I listed above to sign off on it as well.

robscott · 2023-09-11T18:08:46Z

@sunjayBhatia @mlavacca @arkodg can one of you take a look at this? Would love to get this into v0.8.1 (this week) if possible.

arkodg

/approve

k8s-ci-robot · 2023-09-11T18:14:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, levikobi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~conformance/OWNERS~~ [arkodg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

robscott · 2023-09-11T18:17:31Z

/cherry-pick release-0.8

k8s-infra-cherrypick-robot · 2023-09-11T18:17:33Z

@robscott: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot · 2023-09-11T18:30:53Z

@robscott: new pull request created: #2387

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add conformance for multiple mirror filters

d25b42f

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2023

k8s-ci-robot requested review from LiorLieberman and Xunzhuo August 28, 2023 15:17

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2023

shaneutt added this to the v1.0.0 milestone Aug 28, 2023

shaneutt added the release-blocker MUST be completed to complete the milestone label Aug 28, 2023

LiorLieberman reviewed Aug 28, 2023

View reviewed changes

levikobi and others added 2 commits August 29, 2023 07:28

Apply suggestions from code review

ac6c497

Co-authored-by: Lior Lieberman <[email protected]>

Apply all suggestions from code review

dcefa0f

levikobi requested a review from LiorLieberman August 29, 2023 04:39

LiorLieberman reviewed Aug 29, 2023

View reviewed changes

conformance/utils/http/mirror.go Outdated Show resolved Hide resolved

k8s-ci-robot assigned LiorLieberman Aug 29, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023

k8s-ci-robot assigned shaneutt Aug 30, 2023

Update conformance/utils/http/mirror.go

937dcb3

Co-authored-by: Lior Lieberman <[email protected]>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023

k8s-ci-robot requested review from arkodg, mlavacca and sunjayBhatia September 5, 2023 17:18

arkodg approved these changes Sep 11, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023

k8s-ci-robot merged commit c80d8a3 into kubernetes-sigs:main Sep 11, 2023

k8s-infra-cherrypick-robot mentioned this pull request Sep 11, 2023

[release-0.8] Add conformance for multiple mirror filters #2387

Merged

Add conformance for multiple mirror filters #2359

Add conformance for multiple mirror filters #2359

Uh oh!

Conversation

levikobi commented Aug 28, 2023

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiorLieberman Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

levikobi Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

LiorLieberman Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

LiorLieberman commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

levikobi commented Aug 29, 2023

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LiorLieberman commented Aug 30, 2023

Uh oh!

LiorLieberman commented Aug 30, 2023

Uh oh!

robscott commented Sep 5, 2023

Uh oh!

robscott commented Sep 5, 2023

Uh oh!

robscott commented Sep 11, 2023

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Sep 11, 2023

Uh oh!

robscott commented Sep 11, 2023

Uh oh!

k8s-infra-cherrypick-robot commented Sep 11, 2023

Uh oh!

k8s-infra-cherrypick-robot commented Sep 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LiorLieberman commented Aug 28, 2023 •

edited

Loading