Skip to content

Commit d90f0f4

Browse files
committed
conformance-profile: Remove experimental build tag
This is to make it easier for some implementation that imports the conformance test framework and run tests in the same codebase. Understand that cleaning up of similar/duplicated code is required to have a clean conformance test framework, however, such work might delay v1.0.0 GA release, hence, I only remove the build tag to remove the soft blocker in this PR. Subsequent cleanup/optimization can be done later. Relates: #2242 Signed-off-by: Tam Mach <[email protected]>
1 parent e9b02c5 commit d90f0f4

File tree

10 files changed

+7
-42
lines changed

10 files changed

+7
-42
lines changed

conformance/apis/v1alpha1/conformancereport.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63
@@ -71,7 +68,7 @@ type Implementation struct {
7168
// addresses.
7269
// Rather than Github usernames or email addresses you can provide a URL to the relevant
7370
// support pages for the project. Ideally this would be something like the issue creation page
74-
// on a repository, but for projects without a publicly exposed repository a general support
71+
// on a repository, but for projects without a publicly exposed repository a general support
7572
// page URL can be provided.
7673
Contact []string `json:"contact"`
7774
}

conformance/apis/v1alpha1/doc.go

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63
@@ -23,17 +20,10 @@ limitations under the License.
2320
// are written in Golang and execute the conformance test suite as a Golang
2421
// library.
2522
//
26-
// Note that currently all sub-packages are considered "experimental" in that
27-
// they aren't intended for general use or to be distributed as part of a
28-
// release so there is no way to use them by default when using the Golang
29-
// library at this time. If you don't know for sure that you want to use these
30-
// features, then you should not use them. If you would like to opt into these
31-
// unreleased features use Go build tags to enable them, e.g.:
32-
//
33-
// $ GOFLAGS='-tags=experimental' go test ./conformance/... -args ${CONFORMANCE_ARGS}
23+
// $ go test ./conformance/... -args ${CONFORMANCE_ARGS}
3424
//
35-
// Please note that everything here is considered experimental and subject to
36-
// change. Expect breaking changes and/or complete removals if you start using
37-
// them.
25+
// While the experiment build tag is removed, please note that everything here
26+
// is still considered experimental and subject to change. Expect breaking changes
27+
// and/or complete removals if you start using them.
3828

3929
package v1alpha1

conformance/apis/v1alpha1/profilereport.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63

conformance/apis/v1alpha1/result.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63

conformance/apis/v1alpha1/statistics.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63

conformance/experimental_conformance_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63

conformance/utils/flags/experimental_flags.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63

conformance/utils/suite/experimental_profiles.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63

conformance/utils/suite/experimental_reports.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63
@@ -21,6 +18,7 @@ package suite
2118

2219
import (
2320
"k8s.io/apimachinery/pkg/util/sets"
21+
2422
confv1a1 "sigs.k8s.io/gateway-api/conformance/apis/v1alpha1"
2523
)
2624

conformance/utils/suite/experimental_suite.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
//go:build experimental
2-
// +build experimental
3-
41
/*
52
Copyright 2023 The Kubernetes Authors.
63
@@ -29,6 +26,7 @@ import (
2926

3027
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3128
"k8s.io/apimachinery/pkg/util/sets"
29+
3230
"sigs.k8s.io/gateway-api/conformance"
3331
confv1a1 "sigs.k8s.io/gateway-api/conformance/apis/v1alpha1"
3432
"sigs.k8s.io/gateway-api/conformance/utils/config"

0 commit comments

Comments
 (0)